lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 08 Dec 2020 12:57:03 +0000 From: David Howells <dhowells@...hat.com> To: Gabriel Krisman Bertazi <krisman@...labora.com> Cc: dhowells@...hat.com, viro@...iv.linux.org.uk, tytso@....edu, khazhy@...gle.com, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, kernel@...labora.com Subject: Re: [PATCH 3/8] watch_queue: Support a text field at the end of the notification Gabriel Krisman Bertazi <krisman@...labora.com> wrote: > This allow notifications to send text information to userspace without > having to copy it to a temporary buffer to then copy to the ring. One > use case to pass text information in notifications is for error > reporting, where more debug information might be needed, but we don't > want to explode the number of subtypes of notifications. For instance, > ext4 can have a single inode error notification subtype, and pass more > information on the cause of the error in this field. I'm generally okay with this, but you really need to note that if you make use of this for a subtype, you don't get to add more fields for that subtype unless there's an offset to it. Speaking of that, you need to update: Documentation/watch_queue.rst since you're changing the API. The "Watch Sources" section will also need altering to indicate that superblock events are now a thing. David
Powered by blists - more mailing lists