linux-ext4 - Re: [PATCH] mke2fs.8: Improve valid block size documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201216102213.GC21258@quack2.suse.cz>
Date:   Wed, 16 Dec 2020 11:22:13 +0100
From:   Jan Kara <jack@...e.cz>
To:     "Theodore Y. Ts'o" <tytso@....edu>
Cc:     Jan Kara <jack@...e.cz>, Andreas Dilger <adilger@...ger.ca>,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] mke2fs.8: Improve valid block size documentation

On Tue 15-12-20 13:50:27, Theodore Y. Ts'o wrote:
> On Thu, Oct 15, 2020 at 11:27:31AM +0200, Jan Kara wrote:
> > On Wed 14-10-20 18:56:13, Andreas Dilger wrote:
> > > On Oct 13, 2020, at 7:38 AM, Jan Kara <jack@...e.cz> wrote:
> > > > 
> > > > Explain which valid block sizes mke2fs supports in more detail.
> > > > 
> > > > Signed-off-by: Jan Kara <jack@...e.cz>
> > > 
> > > Should this mention that the default block size is 4096 bytes for most
> > > filesystems?
> > 
> > That would be to the "heuristic" parts. Yes, I agree, I'll add that.
> > 
> > > It might mention e.g. ppc64 or aarch64 can use 64KB page size, but this
> > > is definitely an improvement already.
> > 
> > Yeah, I can add that to the "page size" part. But with these archs there's
> > a catch that page size can be configured in the kernel config so the
> > formulation will need to be a bit more careful. But I'll add something.
> > 
> > > Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> > 
> > Thanks! I'll send v2.
> 
> Did you ever send a v2 of this patch?  I can't seem to find it in my
> archives or in patchwork.

I think I did but probably it got lost somewhere. Anyway, I've resent it
now. Thanks for noticing!

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR