linux-ext4 - Re: [PATCH 7/8] ext4: Fix superblock checksum failure when setting password salt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X9uBLMhQFPQIGUFT@mit.edu>
Date:   Thu, 17 Dec 2020 11:02:52 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-ext4@...r.kernel.org,
        harshad shirwadkar <harshadshirwadkar@...il.com>,
        Michael Halcrow <mhalcrow@...gle.com>
Subject: Re: [PATCH 7/8] ext4: Fix superblock checksum failure when setting
 password salt

On Wed, Dec 16, 2020 at 11:18:43AM +0100, Jan Kara wrote:
> When setting password salt in the superblock, we forget to recompute the
> superblock checksum so it will not match until the next superblock
> modification which recomputes the checksum. Fix it.
> 
> CC: Michael Halcrow <mhalcrow@...gle.com>
> Reported-by: Andreas Dilger <adilger@...ger.ca>
> Fixes: 9bd8212f981e ("ext4 crypto: add encryption policy and password salt support")
> Signed-off-by: Jan Kara <jack@...e.cz>

Thanks, applied.

						- Ted