lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 Jan 2021 10:10:48 +0100 From: Christoph Hellwig <hch@....de> To: Eric Biggers <ebiggers@...nel.org> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-xfs@...r.kernel.org, Theodore Ts'o <tytso@....edu>, Christoph Hellwig <hch@....de> Subject: Re: [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit On Mon, Jan 04, 2021 at 04:54:49PM -0800, Eric Biggers wrote: > + } else { > + /* > + * Else it's either I_DIRTY_PAGES, I_DIRTY_TIME, or nothing. > + * (We don't support setting both I_DIRTY_PAGES and I_DIRTY_TIME > + * in one call to __mark_inode_dirty().) > + */ > + dirtytime = flags & I_DIRTY_TIME; > + WARN_ON_ONCE(dirtytime && (flags != I_DIRTY_TIME)); No need for the inner braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@....de>
Powered by blists - more mailing lists