lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 09:31:20 -0800 From: "Darrick J. Wong" <djwong@...nel.org> To: Eric Biggers <ebiggers@...nel.org> Cc: linux-fsdevel@...r.kernel.org, linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, Theodore Ts'o <tytso@....edu>, Christoph Hellwig <hch@....de> Subject: Re: [PATCH v2 12/12] xfs: remove a stale comment from xfs_file_aio_write_checks() On Fri, Jan 08, 2021 at 11:59:03PM -0800, Eric Biggers wrote: > From: Eric Biggers <ebiggers@...gle.com> > > The comment in xfs_file_aio_write_checks() about calling file_modified() > after dropping the ilock doesn't make sense, because the code that > unconditionally acquires and drops the ilock was removed by > commit 467f78992a07 ("xfs: reduce ilock hold times in > xfs_file_aio_write_checks"). > > Remove this outdated comment. > > Reviewed-by: Christoph Hellwig <hch@....de> > Signed-off-by: Eric Biggers <ebiggers@...gle.com> Yep, thanks for the update. :) Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com> --D > --- > fs/xfs/xfs_file.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 5b0f93f738372..4927c6653f15d 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -389,12 +389,6 @@ xfs_file_aio_write_checks( > } else > spin_unlock(&ip->i_flags_lock); > > - /* > - * Updating the timestamps will grab the ilock again from > - * xfs_fs_dirty_inode, so we have to call it after dropping the > - * lock above. Eventually we should look into a way to avoid > - * the pointless lock roundtrip. > - */ > return file_modified(file); > } > > -- > 2.30.0 >
Powered by blists - more mailing lists