lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Jan 2021 22:32:51 -0500 From: "Theodore Ts'o" <tytso@....edu> To: Jan Kara <jack@...e.cz> Cc: Yi Li <yili@...hong.com>, yilikernel@...il.com, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Use IS_ERR instead of IS_ERR_OR_NULL and set inode null when IS_ERR. On Wed, Jan 06, 2021 at 02:02:11PM +0100, Jan Kara wrote: > On Wed 30-12-20 11:38:27, Yi Li wrote: > > 1: ext4_iget/ext4_find_extent never returns NULL, use IS_ERR > > instead of IS_ERR_OR_NULL to fix this. > > > > 2: ext4_fc_replay_inode should set the inode to NULL when IS_ERR. > > and go to call iput properly. > > > > Signed-off-by: Yi Li <yili@...hong.com> > > Thanks for the patch! It looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@...e.cz> Thanks, applied. - Ted
Powered by blists - more mailing lists