linux-ext4 - Re: [RFC PATCH 00/37] block: introduce bio_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB49652C7B57396757FF064C6686A20@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Wed, 20 Jan 2021 03:27:55 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "drbd-dev@...ts.linbit.com" <drbd-dev@...ts.linbit.com>,
        "linux-bcache@...r.kernel.org" <linux-bcache@...r.kernel.org>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
        "cluster-devel@...hat.com" <cluster-devel@...hat.com>
CC:     "jfs-discussion@...ts.sourceforge.net" 
        <jfs-discussion@...ts.sourceforge.net>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "philipp.reisner@...bit.com" <philipp.reisner@...bit.com>,
        "lars.ellenberg@...bit.com" <lars.ellenberg@...bit.com>,
        "efremov@...ux.com" <efremov@...ux.com>,
        "colyli@...e.de" <colyli@...e.de>,
        "kent.overstreet@...il.com" <kent.overstreet@...il.com>,
        "agk@...hat.com" <agk@...hat.com>,
        "snitzer@...hat.com" <snitzer@...hat.com>,
        "song@...nel.org" <song@...nel.org>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "clm@...com" <clm@...com>,
        "josef@...icpanda.com" <josef@...icpanda.com>,
        "dsterba@...e.com" <dsterba@...e.com>,
        "tytso@....edu" <tytso@....edu>,
        "adilger.kernel@...ger.ca" <adilger.kernel@...ger.ca>,
        "rpeterso@...hat.com" <rpeterso@...hat.com>,
        "agruenba@...hat.com" <agruenba@...hat.com>,
        "darrick.wong@...cle.com" <darrick.wong@...cle.com>,
        "shaggy@...nel.org" <shaggy@...nel.org>,
        Damien Le Moal <Damien.LeMoal@....com>,
        Naohiro Aota <Naohiro.Aota@....com>,
        "jth@...nel.org" <jth@...nel.org>, "tj@...nel.org" <tj@...nel.org>,
        "osandov@...com" <osandov@...com>,
        "bvanassche@....org" <bvanassche@....org>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>,
        "asml.silence@...il.com" <asml.silence@...il.com>,
        "jefflexu@...ux.alibaba.com" <jefflexu@...ux.alibaba.com>
Subject: Re: [RFC PATCH 00/37] block: introduce bio_init_fields()

On 1/18/21 21:06, Chaitanya Kulkarni wrote:
> Hi,
>
> This is a *compile only RFC* which adds a generic helper to initialize
> the various fields of the bio that is repeated all the places in
> file-systems, block layer, and drivers.
>
> The new helper allows callers to initialize various members such as
> bdev, sector, private, end io callback, io priority, and write hints.
>
> The objective of this RFC is to only start a discussion, this it not 
> completely tested at all.                                                                                                            
> Following diff shows code level benefits of this helper :-
>  38 files changed, 124 insertions(+), 236 deletions(-)
>
> -ck
Thanks for replying Mike, Josef and Christoph.

I'll move forward with Christoph's suggestion and get rid of
optional parameters which is making this API hard to use.