linux-ext4 - Re: [PATCH v3 12/12] tests: f_bad_fname: Test fixes of invalid filenames and duplicates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YBI42sG2VcE25h4h@mit.edu>
Date:   Wed, 27 Jan 2021 23:08:58 -0500
From:   "Theodore Ts'o" <tytso@....edu>
To:     Arnaud Ferraris <arnaud.ferraris@...labora.com>
Cc:     linux-ext4@...r.kernel.org, drosen@...gle.com,
        krisman@...labora.com, ebiggers@...nel.org
Subject: Re: [PATCH v3 12/12] tests: f_bad_fname: Test fixes of invalid
 filenames and duplicates

On Thu, Dec 17, 2020 at 06:35:44PM +0100, Arnaud Ferraris wrote:
> From: Gabriel Krisman Bertazi <krisman@...labora.com>
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>
> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@...labora.com>

It looks like you didn't regenerate the expect.1 file after changing
the problem description.

% cat f_bad_fname.failed 
--- /usr/projects/e2fsprogs/e2fsprogs/tests/f_bad_fname/expect.1	2021-01-28 03:20:36.813595045 +0000
+++ f_bad_fname.1.log	2021-01-28 03:25:49.940137813 +0000
@@ -1,9 +1,9 @@
 Pass 1: Checking inodes, blocks, and sizes
 Pass 2: Checking directory structure
-Entry 'AM-^?' in /ci_dir (12) has illegal characters in its name.
+Entry 'AM-^?' in /ci_dir (12) has illegal UTF-8 characters in its name.
 Fix? yes
 
-Entry 'AM-~' in /ci_dir (12) has illegal characters in its name.
+Entry 'AM-~' in /ci_dir (12) has illegal UTF-8 characters in its name.
 Fix? yes
 
 Duplicate entry 'A.' found.

I'll fix this up in my tree.

     	           	      	       - Ted