lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Feb 2021 10:01:35 -0800 From: Eric Biggers <ebiggers@...nel.org> To: Chaitanya Kulkarni <chaitanya.kulkarni@....com> Cc: linux-block@...r.kernel.org, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org, axboe@...nel.dk, tytso@....edu, adilger.kernel@...ger.ca, jaegeuk@...nel.org, chao@...nel.org, johannes.thumshirn@....com, damien.lemoal@....com, bvanassche@....org, dongli.zhang@...cle.com, clm@...com, ira.weiny@...el.com, dsterba@...e.com, hch@...radead.org, dave.hansen@...el.com Subject: Re: [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write() On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote: > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com> No explanation in commit message? There isn't much explanation needed for this, but there should be at least one sentence. Likewise for the other patches. > fs/f2fs/verity.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c > index 44e057bdc416..ca019685a944 100644 > --- a/fs/f2fs/verity.c > +++ b/fs/f2fs/verity.c > @@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, > PAGE_SIZE - offset_in_page(pos)); > struct page *page; > void *fsdata; > - void *addr; > int res; > > res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0, > @@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, > if (res) > return res; > > - addr = kmap_atomic(page); > - memcpy(addr + offset_in_page(pos), buf, n); > - kunmap_atomic(addr); > + memcpy_to_page(page, offset_in_page(pos) buf, n); This is missing a comma between 'offset_in_page(pos)' and 'buf'. Otherwise the patches to fs/{ext4,f2fs}/verity.c look fine; thanks for doing this! - Eric
Powered by blists - more mailing lists