| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210223174156.308507-1-harshads@google.com> Date: Tue, 23 Feb 2021 09:41:53 -0800 From: Harshad Shirwadkar <harshadshirwadkar@...il.com> To: linux-ext4@...r.kernel.org Cc: tytso@....edu, Harshad Shirwadkar <harshadshirwadkar@...il.com> Subject: [PATCH v2 1/4] e2fsck: don't ignore return values in e2fsck_rewrite_extent_tree From: Harshad Shirwadkar <harshadshirwadkar@...il.com> Don't ignore return values of library function calls in e2fsck_rewrite_extent_tree. Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@...il.com> --- e2fsck/extents.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/e2fsck/extents.c b/e2fsck/extents.c index 600dbc97..018737af 100644 --- a/e2fsck/extents.c +++ b/e2fsck/extents.c @@ -290,8 +290,10 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list) errcode_t err; memset(&inode, 0, sizeof(inode)); - ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), - sizeof(inode)); + err = ext2fs_read_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), + sizeof(inode)); + if (err) + return err; /* Skip deleted inodes and inline data files */ if (inode.i_flags & EXT4_INLINE_DATA_FL) @@ -305,11 +307,11 @@ errcode_t e2fsck_rewrite_extent_tree(e2fsck_t ctx, struct extent_list *list) &blk_count); if (err) return err; - ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count); - ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), - sizeof(inode)); - - return 0; + err = ext2fs_iblk_set(ctx->fs, EXT2_INODE(&inode), blk_count); + if (err) + return err; + return ext2fs_write_inode_full(ctx->fs, list->ino, EXT2_INODE(&inode), + sizeof(inode)); } errcode_t e2fsck_read_extents(e2fsck_t ctx, struct extent_list *extents) -- 2.30.0.617.g56c4b15f3c-goog
Powered by blists - more mailing lists