linux-ext4 - Re: [PATCH] ext4: Add xattr commands to compat ioctl handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDl0UlcgobAHx0v5@gmail.com>
Date:   Fri, 26 Feb 2021 14:21:06 -0800
From:   Eric Biggers <ebiggers@...nel.org>
To:     Sarthak Kukreti <sarthakkukreti@...omium.org>
Cc:     Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH] ext4: Add xattr commands to compat ioctl handler

On Fri, Feb 26, 2021 at 02:14:41PM -0800, Sarthak Kukreti wrote:
> This allows 32-bit userspace utils to use FS_IOC_FSGETXATTR and 
> FS_IOC_FSSETXATTR on a 64-bit kernel.
> 
> Signed-off-by: Sarthak Kukreti <sarthakkukreti@...omium.org>
> ---
>  fs/ext4/ioctl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index f0381876a7e5b..055c26296ab46 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -1371,6 +1371,8 @@ long ext4_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  			return -EFAULT;
>  		return ext4_ioctl_group_add(file, &input);
>  	}
> +	case EXT4_IOC_FSGETXATTR:
> +	case EXT4_IOC_FSSETXATTR:
>  	case EXT4_IOC_MOVE_EXT:
>  	case EXT4_IOC_RESIZE_FS:
>  	case FITRIM:

These were already added to the list by commit a54d8d34d235
("ext4: Add EXT4_IOC_FSGETXATTR/EXT4_IOC_FSSETXATTR to compat_ioctl").

- Eric