linux-ext4 - Re: [PATCH] misc: remove useless code in set_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <F8991EA4-20AB-4785-83A6-8BC159EF3970@dilger.ca>
Date:   Wed, 3 Mar 2021 13:20:33 -0700
From:   Andreas Dilger <adilger@...ger.ca>
To:     Zhiqiang Liu <liuzhiqiang26@...wei.com>
Cc:     linux-ext4@...r.kernel.org, "Theodore Y. Ts'o" <tytso@....edu>,
        harshad shirwadkar <harshadshirwadkar@...il.com>,
        linfeilong <linfeilong@...wei.com>,
        lihaotian <lihaotian9@...wei.com>
Subject: Re: [PATCH] misc: remove useless code in set_inode_xattr()

On 2021/2/26 9:22, Zhiqiang Liu wrote:
> 
> In set_inode_xattr(), there are two returns as follows,
> -
>  return retval;
>  return 0;
> -
> Here, we remove useless 'return 0;' code.
> 
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>

Reviewed-by: Andreas Dilger <adilger@...ger.ca>

> ---
> misc/create_inode.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/misc/create_inode.c b/misc/create_inode.c
> index 54d8d343..d62e1cb4 100644
> --- a/misc/create_inode.c
> +++ b/misc/create_inode.c
> @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
> 		retval = retval ? retval : close_retval;
> 	}
> 	return retval;
> -	return 0;
> }
> #else /* HAVE_LLISTXATTR */
> static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
> 



Cheers, Andreas






Download attachment "signature.asc" of type "application/pgp-signature" (874 bytes)