linux-ext4 - Re: [PATCH] iomap: Fix negative assignment to unsigned sis->pages in iomap_swapfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5dd2a59-d228-31ee-3f47-e54838c11b4e@linux.ibm.com>
Date:   Thu, 4 Mar 2021 15:56:47 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org
Cc:     linux-fsdevel@...r.kernel.org, anju@...ux.vnet.ibm.com
Subject: Re: [PATCH] iomap: Fix negative assignment to unsigned sis->pages in
 iomap_swapfile_activate



On 3/4/21 11:51 AM, Ritesh Harjani wrote:
> In case if isi.nr_pages is 0, we are making sis->pages (which is
> unsigned int) a huge value in iomap_swapfile_activate() by assigning -1.
> This could cause a kernel crash in kernel v4.18 (with below signature).
> Or could lead to unknown issues on latest kernel if the fake big swap gets
> used.
> 
> Fix this issue by returning -EINVAL in case of nr_pages is 0, since it
> is anyway a invalid swapfile. Looks like this issue will be hit when
> we have pagesize < blocksize type of configuration.

Oops I meant blocksize < pagesize type of configuration.