linux-ext4 - Re: [PATCH] ext4: add rename whiteout support for fast commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Mar 2021 11:33:13 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Harshad Shirwadkar <harshadshirwadkar@...il.com>
Cc:     Ext4 <linux-ext4@...r.kernel.org>, Theodore Tso <tytso@....edu>
Subject: Re: [PATCH] ext4: add rename whiteout support for fast commit

On Wed, Mar 17, 2021 at 12:19 AM Harshad Shirwadkar
<harshadshirwadkar@...il.com> wrote:
>
> This patch adds rename whiteout support in fast commits. Note that the

My only problem with this change is the subject.
It sounds like rename whiteout was not possible and now support was added
and it is now possible. This is not the case.
The truth is that rename whiteout is supported but broken with fast commits.
So the subject should reflect that this is a FIX commit, i.e.:

"ext4: fix rename whiteout with fast commit"

And patch should have a Fixes: tag with the commit that added fast commit
support to rename.

Otherwise, patch has stray newline but the rest looks pretty straightforward
to me.

Thanks,
Amir.