lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Apr 2021 18:16:31 +0800 From: Fengnan Chang <changfengnan@...o.com> To: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org Cc: Fengnan Chang <changfengnan@...o.com> Subject: [PATCH v2] ext4: fix error code in ext4_commit_super We should set the error code when ext4_commit_super check argument failed. Found in code review. Fixes: c4be0c1dc4cdc ("filesystem freeze: add error handling of write_super_lockfs/unlockfs"). Signed-off-by: Fengnan Chang <changfengnan@...o.com> --- fs/ext4/super.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 03373471131c..1130599c87dc 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5500,8 +5500,10 @@ static int ext4_commit_super(struct super_block *sb, int sync) struct buffer_head *sbh = EXT4_SB(sb)->s_sbh; int error = 0; - if (!sbh || block_device_ejected(sb)) - return error; + if (!sbh) + return -EINVAL; + if (block_device_ejected(sb)) + return -ENODEV; /* * If the file system is mounted read-only, don't update the -- 2.29.0
Powered by blists - more mailing lists