linux-ext4 - Re: [ext4:dev 9/17] fs/ext4/fast_commit.c:1738:5: warning: format specifies type 'int' but the argument has type 'unsigned long'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 9 Apr 2021 22:44:35 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        "Theodore Ts'o" <tytso@....edu>, Jan Kara <jack@...e.cz>
Subject: Re: [ext4:dev 9/17] fs/ext4/fast_commit.c:1738:5: warning: format
 specifies type 'int' but the argument has type 'unsigned long'

On Fri, Apr 9, 2021 at 8:59 PM kernel test robot <lkp@...el.com> wrote:

>
> All warnings (new ones prefixed by >>):
>
> >> fs/ext4/fast_commit.c:1738:5: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
>                                    map.m_flags & EXT4_MAP_UNWRITTEN,
>                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    include/linux/jbd2.h:64:51: note: expanded from macro 'jbd_debug'
>    #define jbd_debug(n, fmt, a...)  no_printk(fmt, ##a)
>                                               ~~~    ^
>    include/linux/printk.h:140:17: note: expanded from macro 'no_printk'
>                    printk(fmt, ##__VA_ARGS__);             \
>                           ~~~    ^~~~~~~~~~~
>    1 warning generated.
> --
> >> fs/jbd2/recovery.c:256:54: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
>                    jbd_debug(3, "Processing fast commit blk with seq %d");
>                                                                      ~^
>    include/linux/jbd2.h:64:44: note: expanded from macro 'jbd_debug'
>    #define jbd_debug(n, fmt, a...)  no_printk(fmt, ##a)
>                                               ^~~
>    include/linux/printk.h:140:10: note: expanded from macro 'no_printk'
>                    printk(fmt, ##__VA_ARGS__);             \
>                           ^~~
>    1 warning generated.
>

I sent a patch now. For some reason I ended up testing with -Wempty-body enabled
but all -Wformat warnings disabled when I tested this before sending.

        Arnd