linux-ext4 - Re: [PATCH v3] ext4: Fix ext4_error_err save negative errno into superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YHD3PbAv1ywmAVSs@mit.edu>
Date:   Fri, 9 Apr 2021 20:54:21 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Ye Bin <yebin10@...wei.com>
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Liu Zhi Qiang <liuzhiqiang26@...wei.com>,
        Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH v3] ext4: Fix ext4_error_err save negative errno into
 superblock

On Tue, Apr 06, 2021 at 10:53:31AM +0800, Ye Bin wrote:
> As write_mmp_block return 1 when buffer isn't uptodate, return -EIO is
> more appropriate.
> 
> Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
> Reported-by: Liu Zhi Qiang <liuzhiqiang26@...wei.com>
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>

Thanks, applied.

					- Ted