lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Apr 2021 15:42:27 +0200 From: Jan Kara <jack@...e.cz> To: Christoph Hellwig <hch@...radead.org> Cc: Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org, Ted Tso <tytso@....edu>, Amir Goldstein <amir73il@...il.com>, Dave Chinner <david@...morbit.com> Subject: Re: [PATCH 5/7] xfs: Convert to use i_mapping_sem On Tue 13-04-21 14:05:12, Christoph Hellwig wrote: > On Tue, Apr 13, 2021 at 01:28:49PM +0200, Jan Kara wrote: > > Use i_mapping_sem instead of XFS internal i_mmap_lock. The intended > > purpose of i_mapping_sem is exactly the same. > > Might be worth mentioning here that the locking in __xfs_filemap_fault > changes because filemap_fault already takes i_mapping_sem? Sure, will add. > > > * mmap_lock (MM) > > * sb_start_pagefault(vfs, freeze) > > - * i_mmaplock (XFS - truncate serialisation) > > + * i_mapping_sem (XFS - truncate serialisation) > > This is sort of VFS now, isn't it? Right, I'll update the comment. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@....de> Thanks! Honza -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists