linux-ext4 - Re: [PATCH v5] e2image: add option to ignore fs errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4972D70F-1765-413B-971B-CE4147993B29@dilger.ca>
Date:   Fri, 23 Apr 2021 10:25:18 -0600
From:   Andreas Dilger <adilger@...ger.ca>
To:     Artem Blagodarenko <artem.blagodarenko@...il.com>
Cc:     linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca,
        Alexey Lyashkov <alexey.lyashkov@....com>,
        Artem Blagodarenko <artem.blagodarenko@....com>
Subject: Re: [PATCH v5] e2image: add option to ignore fs errors

On Apr 23, 2021, at 07:30, Artem Blagodarenko <artem.blagodarenko@...il.com> wrote:
> 
> Add extended "-E ignore_error" option to be more tolerant
> to fs errors while scanning inode extents.

Not to be pedantic, but should this allow "ignore_errors", since it will
presumably ignore more than one error.  If already using "ignore_error"
in the field you could accept both for some time until able to change over,
as we've done with "ea_inode" vs. "large_xattr" in the Lustre e2fsprogs
for years. 

> Changes since preveious version:
> - rebased on top of the master

This should go after the "---" so that it isn't in the final commit message. 

> Signed-off-by: Alexey Lyashkov <alexey.lyashkov@....com>
> Signed-off-by: Artem Blagodarenko <artem.blagodarenko@....com>
> Cray-bug-id: LUS-1922
> Change-Id: Ib79300656726839b1d3b7ee1dd0793c60679d296
> Reviewed-by: Andreas Dilger <adilger@...ger.ca>
> ---

One typo in the man page below:

> diff --git a/misc/e2image.8.in b/misc/e2image.8.in
> index cb176f5d..45a06d3b 100644
> --- a/misc/e2image.8.in
> +++ b/misc/e2image.8.in
> @@ -137,6 +144,16 @@ useful if the file system is being cloned to a flash-based storage device
> (where reads are very fast and where it is desirable to avoid unnecessary
> writes to reduce write wear on the device).
> .TP
> +.BI \-E " extended_options"
> +Set e2iamge extended options.

"e2image"

Ted could fix this in the final commit
Cheers, Andreas

>  Extended options are comma separated, and
> +may take an argument using the equals ('=') sign.  The following options
> +are supported:
> +.RS 1.2i
> +.TP
> +.BI ignore_error
> +Grab an image from a corrupted FS and ignore fs errors.
> +.RE
> +.TP
> .B \-f
> Override the read-only requirement for the source filesystem when saving
> the image file using the