linux-ext4 - Re: [PATCH] e2fsck: fix portability problems caused by unaligned accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 May 2021 11:18:51 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Andreas Dilger <adilger@...ger.ca>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>,
        harshads@...gle.com
Subject: Re: [PATCH] e2fsck: fix portability problems caused by unaligned
 accesses

On Tue, May 04, 2021 at 12:29:21AM -0600, Andreas Dilger wrote:
> > @@ -344,10 +361,10 @@ static int ext4_fc_replay_scan(journal_t *j, struct buffer_head *bh,
> > 						offsetof(struct ext4_fc_tail,
> > 						fc_crc));
> > 			jbd_debug(1, "tail tid %d, expected %d\n",
> > -					le32_to_cpu(tail->fc_tid),
> > +					get_le32(&tail->fc_tid),
> > 					expected_tid);
> > -			if (le32_to_cpu(tail->fc_tid) == expected_tid &&
> > -				le32_to_cpu(tail->fc_crc) == state->fc_crc) {
> > +			if (get_le32(&tail->fc_tid) == expected_tid &&
> > +				get_le32(&tail->fc_crc) == state->fc_crc) {
> 
> (style) better to align continued line after '(' on previous line?  That way
> it can be distinguished from the next (body) line more easily

Thanks, I fixed up the whitespace style issues (which were in the
original code, but while we're modifying these lines, might as well
fix them up).

					- Ted