linux-ext4 - Re: [PATCH] ext4: remove set but rewrite variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B5603A0A-D24E-46A2-94B6-79451E39141C@gmail.com>
Date:   Mon, 17 May 2021 11:05:32 +0300
From:   Благодаренко Артём 
        <artem.blagodarenko@...il.com>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     "Theodore Y. Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: remove set but rewrite variables



> On 17 May 2021, at 05:56, Tian Tao <tiantao6@...ilicon.com> wrote:
> 
> In line 2500 of the ext4_dx_add_entry function, the at variable is
> assigned but not used, and it is reassigned in line 2449, so delete
> the assignment of the at variable in line 2500.
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> ---
> fs/ext4/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index afb9d05..18bbf15 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -2497,7 +2497,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
> 
> 			/* Which index block gets the new entry? */
> 			if (at - entries >= icount1) {
> -				frame->at = at = at - entries - icount1 + entries2;
> +				frame->at = at - entries - icount1 + entries2;
> 				frame->entries = entries = entries2;
> 				swap(frame->bh, bh2);
> 			}
> -- 
> 2.7.4
> 


Hello Tian,

Thank you for the patch. 

Please, clarify, do you think the logic not changed after you patch if "while (frame > frames) {“ loop is not executed or terminated by “break:” in " if (dx_get_count((frame - 1)->entries) < ...“ block?
Also I am not sure code lines numbers in the description are useful for future readers, because they can be changed.

Thank you.