lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 27 May 2021 08:19:26 +0530
From:   riteshh <riteshh@...ux.ibm.com>
To:     chenyichong <chenyichong@...ontech.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] use local variables ei instead of invoking function
 EXT4_I

On 21/05/26 01:29PM, chenyichong wrote:

Thanks for the patch. Looks good to me.
Feel free to add

Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>


> Signed-off-by: chenyichong <chenyichong@...ontech.com>
> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fe6045a46599..a5c4cd1c757b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
>  	ei->i_reserved_data_blocks -= used;
>  	percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
>
> -	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> +	spin_unlock(&ei->i_block_reservation_lock);
>
>  	/* Update quota subsystem for data blocks */
>  	if (quota_claim)
> --
> 2.20.1
>
>
>

Powered by blists - more mailing lists