linux-ext4 - Re: [PATCH] ext4: fsmap: Fix the block/inode bitmap comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210531225101.GA15541@locust>
Date:   Mon, 31 May 2021 15:51:01 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>
Cc:     linux-ext4@...r.kernel.org, Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] ext4: fsmap: Fix the block/inode bitmap comment

On Mon, May 31, 2021 at 09:19:08AM +0530, Ritesh Harjani wrote:
> While debugging fstest ext4/027 failure, found below comment to be wrong and
> confusing. Hence fix it while we are at it.
> 
> Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com>

Doh.  Thanks for fixing that.
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
>  fs/ext4/fsmap.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/fsmap.h b/fs/ext4/fsmap.h
> index 68c8001fee85..ac642be2302e 100644
> --- a/fs/ext4/fsmap.h
> +++ b/fs/ext4/fsmap.h
> @@ -50,7 +50,7 @@ int ext4_getfsmap(struct super_block *sb, struct ext4_fsmap_head *head,
>  #define EXT4_FMR_OWN_INODES	FMR_OWNER('X', 5) /* inodes */
>  #define EXT4_FMR_OWN_GDT	FMR_OWNER('f', 1) /* group descriptors */
>  #define EXT4_FMR_OWN_RESV_GDT	FMR_OWNER('f', 2) /* reserved gdt blocks */
> -#define EXT4_FMR_OWN_BLKBM	FMR_OWNER('f', 3) /* inode bitmap */
> -#define EXT4_FMR_OWN_INOBM	FMR_OWNER('f', 4) /* block bitmap */
> +#define EXT4_FMR_OWN_BLKBM	FMR_OWNER('f', 3) /* block bitmap */
> +#define EXT4_FMR_OWN_INOBM	FMR_OWNER('f', 4) /* inode bitmap */
>  
>  #endif /* __EXT4_FSMAP_H__ */
> -- 
> 2.31.1
>