linux-ext4 - Re: [PATCH v2] ext4: remove redundant check buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YMqIsoyY8iaO/qhP@mit.edu>
Date:   Wed, 16 Jun 2021 19:26:42 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Joseph Qi <joseph.qi@...ux.alibaba.com>
Cc:     adilger.kernel@...ger.ca, riteshh@...ux.ibm.com,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH v2] ext4: remove redundant check buffer_uptodate()

On Mon, Apr 26, 2021 at 02:29:47PM +0800, Joseph Qi wrote:
> Now set_buffer_uptodate() will test first and then set, so we don't have
> to check buffer_uptodate() first, remove it to simplify code.
> 
> Reviewed-by: Ritesh Harjani <riteshh@...ux.ibm.com>
> Signed-off-by: Joseph Qi <joseph.qi@...ux.alibaba.com>

Part of this change was already submitted by Yang Guo from Huawei;
I've applied the portion of this patch which is still applicable
(which was for ext4_buffer_uptodate function)

Thanks,

					- Ted