linux-ext4 - Re: [PATCH] ext4: return error code when ext4_fill_flex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YMthpl31g7j+fB6m@mit.edu>
Date:   Thu, 17 Jun 2021 10:52:22 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, adilger.kernel@...ger.ca
Subject: Re: [PATCH] ext4: return error code when ext4_fill_flex_info() fails

On Mon, May 10, 2021 at 07:10:51PM +0800, Yang Yingliang wrote:
> After commit c89128a00838 ("ext4: handle errors on ext4_commit_super"), 'ret' may
> be set to 0 before calling ext4_fill_flex_info(), if ext4_fill_flex_info() fails
> ext4_mount() doesn't return error code, it makes 'root' is null which causes
> crash in legacy_get_tree().
> 
> Fixes: c89128a00838 ("ext4: handle errors on ext4_commit_super")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Cc: <stable@...r.kernel.org> # v4.18+
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Applied, thanks.

					- Ted