linux-ext4 - Re: [RFC PATCH v4 3/8] jbd2: don't abort the journal when freeing buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNSYPzEWXdt9Tkj4@mit.edu>
Date:   Thu, 24 Jun 2021 10:35:43 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Zhang Yi <yi.zhang@...wei.com>
Cc:     linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        jack@...e.cz, adilger.kernel@...ger.ca, david@...morbit.com,
        hch@...radead.org
Subject: Re: [RFC PATCH v4 3/8] jbd2: don't abort the journal when freeing
 buffers

On Thu, Jun 10, 2021 at 07:24:35PM +0800, Zhang Yi wrote:
> Now that we can be sure the journal is aborted once a buffer has failed
> to be written back to disk, we can remove the journal abort logic in
> jbd2_journal_try_to_free_buffers() which was introduced in
> commit c044f3d8360d ("jbd2: abort journal if free a async write error
> metadata buffer"), because it may cost and propably is not safe.
> 
> Signed-off-by: Zhang Yi <yi.zhang@...wei.com>
> Reviewed-by: Jan Kara <jack@...e.cz>

Applied, thanks.

					- Ted