lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210630082724.50838-7-wuguanghao3@huawei.com> Date: Wed, 30 Jun 2021 16:27:18 +0800 From: wuguanghao <wuguanghao3@...wei.com> To: <linux-ext4@...r.kernel.org>, <artem.blagodarenko@...il.com> CC: <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com>, <wuguanghao3@...wei.com> Subject: [PATCH v2 06/12] append_pathname: check the value returned by realloc In append_pathname(), we need to add a new path to save the value returned by realloc, otherwise the name->path may be NULL, causing segfault Signed-off-by: Wu Guanghao <wuguanghao3@...wei.com> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> --- contrib/fsstress.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/contrib/fsstress.c b/contrib/fsstress.c index 2a983482..07433205 100644 --- a/contrib/fsstress.c +++ b/contrib/fsstress.c @@ -599,7 +599,7 @@ void add_to_flist(int ft, int id, int parent) void append_pathname(pathname_t * name, char *str) { int len; - + char *path; len = strlen(str); #ifdef DEBUG if (len && *str == '/' && name->len == 0) { @@ -609,7 +609,13 @@ void append_pathname(pathname_t * name, char *str) } #endif - name->path = realloc(name->path, name->len + 1 + len); + path = realloc(name->path, name->len + 1 + len); + if (path == NULL) { + fprintf(stderr, "fsstress: append_pathname realloc failed\n"); + chdir(homedir); + abort(); + } + name->path = path; strcpy(&name->path[name->len], str); name->len += len; } -- 2.19.1
Powered by blists - more mailing lists