lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20210630082724.50838-2-wuguanghao3@huawei.com> Date: Wed, 30 Jun 2021 16:27:13 +0800 From: wuguanghao <wuguanghao3@...wei.com> To: <linux-ext4@...r.kernel.org>, <artem.blagodarenko@...il.com> CC: <liuzhiqiang26@...wei.com>, <linfeilong@...wei.com>, <wuguanghao3@...wei.com> Subject: [PATCH v2 01/12] profile_create_node: set magic before strdup(name) to avoid memory leak If new->magic != PROF_MAGIC_NODE, profile_free_node() don't free node. This will cause the node to be unable to be released correctly and a memory leak will occur. Signed-off-by: Wu Guanghao <wuguanghao3@...wei.com> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@...wei.com> Reviewed-by: Wu Bo <wubo40@...wei.com> --- lib/support/profile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/support/profile.c b/lib/support/profile.c index 585ed595..2eb3a9d1 100644 --- a/lib/support/profile.c +++ b/lib/support/profile.c @@ -1093,6 +1093,8 @@ errcode_t profile_create_node(const char *name, const char *value, if (!new) return ENOMEM; memset(new, 0, sizeof(struct profile_node)); + new->magic = PROF_MAGIC_NODE; + new->name = strdup(name); if (new->name == 0) { profile_free_node(new); @@ -1105,7 +1107,6 @@ errcode_t profile_create_node(const char *name, const char *value, return ENOMEM; } } - new->magic = PROF_MAGIC_NODE; *ret_node = new; return 0; -- 2.19.1
Powered by blists - more mailing lists