lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YNyku9CJ3YImhkMA@mit.edu> Date: Wed, 30 Jun 2021 13:07:07 -0400 From: "Theodore Ts'o" <tytso@....edu> To: Ritesh Harjani <riteshh@...ux.ibm.com> Cc: fstests@...r.kernel.org, linux-ext4@...r.kernel.org Subject: Re: [PATCH 7/9] generic/620: Remove -b blocksize option for ext4 On Mon, Jun 14, 2021 at 11:58:11AM +0530, Ritesh Harjani wrote: > ext4 with 64k blocksize fails with below error for this given test which > requires dmhugedisk. Also since dax is not supported for this test, so > make sure to remove -b option, if set by config file for ext4 FSTYP for > the test to then use 4K blocksize by default. > > mkfs.ext4: Input/output error while writing out and closing file system > > Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com> Looking at this test, I'm not convinced it actually does the right thing when the block size is 64k, since the whole point is to test what happens when the block number > INT_MAX. So we should be able to fix the block size to be 1k, which would allow us to use a smaller dmhugedisk, and then skip this test if dax is enabled. OTOH, generic/620 runs pretty quicky, so perhaps it's better to do thie quick fix: hardcode the block size to 4k, and then skip it if dax && page_size != 4k. - Ted
Powered by blists - more mailing lists