lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jul 2021 12:11:54 -0400 From: "Theodore Ts'o" <tytso@....edu> To: Zhang Yi <yi.zhang@...wei.com> Cc: Jan Kara <jack@...e.cz>, linuxppc-dev@...ts.ozlabs.org, Guoqing Jiang <guoqing.jiang@...ux.dev>, Sachin Sant <sachinp@...ux.vnet.ibm.com>, Ext4 Developers List <linux-ext4@...r.kernel.org>, "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org> Subject: Re: [powerpc][5.13.0-next-20210701] Kernel crash while running ltp(chdir01) tests On Fri, Jul 02, 2021 at 09:52:13PM +0800, Zhang Yi wrote: > > Sorry about not catching this problem, this fix is not format corrected, > if you think this fix is OK, I can send a patch after test. The issue I see with your approach, which removes the jbd2_journal_unregister_shrinker() call from jbd2_destsroy_journal(), is that means that *all* callers of jbd2_destroy_journal now have to be responsible for calling jbd2_journal_unregister_shrinker() --- and there a number of call sites to jbd2_journal_unregister_shrinker(): fs/ext4/super.c: err = jbd2_journal_destroy(sbi->s_journal); fs/ext4/super.c: jbd2_journal_destroy(sbi->s_journal); fs/ext4/super.c: jbd2_journal_destroy(journal); fs/ext4/super.c: jbd2_journal_destroy(journal); fs/ext4/super.c: jbd2_journal_destroy(journal); fs/ocfs2/journal.c: if (!jbd2_journal_destroy(journal->j_journal) && !status) { fs/ocfs2/journal.c: jbd2_journal_destroy(journal); fs/ocfs2/journal.c: jbd2_journal_destroy(journal); So it probably makes more sense to keep jbd2_journal_unregister_shrinker() in jbd2_destroy_journal(), since arguably the fact that we are using a shrinker is an internal implementation detail, and the users of jbd2 ideally shouldn't need to be expected to know they have unregister jbd2's shirnkers. Similarly, perhaps we should be moving jbd2_journal_register_shirnker() into jbd2_journal_init_common(). We can un-export the register and unshrink register functions, and declare them as static functions internal to fs/jbd2/journal.c. What do you think? - Ted
Powered by blists - more mailing lists