linux-ext4 - Re: [PATCH] ext4: fix flags validity checking for EXT4_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Jul 2021 15:45:46 -0700
From:   Leah Rumancik <leah.rumancik@...il.com>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT

On Fri, Jul 02, 2021 at 01:34:25PM -0400, Theodore Ts'o wrote:
> Use the correct bitmask when checking for any not-yet-supported flags.
> 
> Fixes: 351a0a3fbc35 ("ext4: add ioctl EXT4_IOC_CHECKPOINT")
> Signed-off-by: Theodore Ts'o <tytso@....edu>
> Cc: Leah Rumancik <leah.rumancik@...il.com>
> ---
>  fs/ext4/ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 5730aeca563c..6eed6170aded 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -823,7 +823,7 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
>  	if (!EXT4_SB(sb)->s_journal)
>  		return -ENODEV;
>  
> -	if (flags & ~JBD2_JOURNAL_FLUSH_VALID)
> +	if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
>  		return -EINVAL;
>  
>  	q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);
> -- 
> 2.31.0
> 

Thanks for the fix.

Reviewed-by: Leah Rumancik <leah.rumancik@...il.com>

-Leah