linux-ext4 - Re: [PATCH] ext4: eliminate bogus error in ext4_data_block_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOEHmjjY9facxtIY@mit.edu>
Date:   Sat, 3 Jul 2021 20:58:02 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Tahsin Erdogan <trdgn@...zon.com>
Cc:     Jan Kara <jack@...e.cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org, Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: eliminate bogus error in
 ext4_data_block_valid_rcu()

On Sat, Jul 03, 2021 at 04:05:55PM -0700, Tahsin Erdogan wrote:
> Mainline commit ce9f24cccdc0 ("ext4: check journal inode extents more carefully")
> enabled validity checks for journal inode's data blocks. This change got
> ported to stable branches, but the backport for 4.19 has a bug where it will
> flag an error even when system block entry's inode number matches journal
> inode.

Tahsin,

If I understand the commit description, this patch is only intended
for the 4.19 stable kernel.  If this is the case, I'd suggest using
the Subject prefix [PATCH 4.19] for future patches.  This is more
likely to be clearer (via a quick glance at the Subject line) for
subsystem maintainers, as well as for stable kernel maintainers, that
this is meant for the stable kernel.  It would perhaps also be useful
if you could indicate whether a similar fix is needed for 4.14, and
other older LTS kernels, or whether the only stable backport which had
this bug was 4.19.

Cheers,

					- Ted

P.S.  Great to see you've landed at Amazon!  It's been a while; if I
have a chance to make it out to Seattle, one of these days, it would
be great to catch up.