linux-ext4 - Re: [PATCH -v2] ext4: inline jbd2_journal_[un]register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecd3fa6b-7b49-74b8-cdfa-a1f00d92ec51@nvidia.com>
Date:   Mon, 5 Jul 2021 19:29:18 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Theodore Ts'o <tytso@....edu>,
        Ext4 Developers List <linux-ext4@...r.kernel.org>
CC:     Jan Kara <jack@...e.cz>, Zhang Yi <yi.zhang@...wei.com>,
        Sachin Sant <sachinp@...ux.vnet.ibm.com>,
        linux-tegra <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH -v2] ext4: inline jbd2_journal_[un]register_shrinker()


On 05/07/2021 15:50, Theodore Ts'o wrote:
> The function jbd2_journal_unregister_shrinker() was getting called
> twice when the file system was getting unmounted.  On Power and ARM
> platforms this was causing kernel crash when unmounting the file
> system, when a percpu_counter was destroyed twice.
> 
> Fix this by removing jbd2_journal_[un]register_shrinker() functions,
> and inlining the shrinker setup and teardown into
> journal_init_common() and jbd2_journal_destroy().  This means that
> ext4 and ocfs2 now no longer need to know about registering and
> unregistering jbd2's shrinker.
> 
> Also, while we're at it, rename the percpu counter from
> j_jh_shrink_count to j_checkpoint_jh_count, since this makes it
> clearer what this counter is intended to track.
> 
> Fixes: 4ba3fcdde7e3 ("jbd2,ext4: add a shrinker to release checkpointed buffers")
> Reported-by: Jon Hunter <jonathanh@...dia.com>
> Reported-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>
> Tested-by: Sachin Sant <sachinp@...ux.vnet.ibm.com>
> Reviewed-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Theodore Ts'o <tytso@....edu>

Thanks, works for me.

Tested-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon

-- 
nvpublic