lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Jul 2021 09:39:58 +0800 From: Zhiqiang Liu <liuzhiqiang26@...wei.com> To: "Theodore Y. Ts'o" <tytso@....edu>, wuguanghao <wuguanghao3@...wei.com> CC: <linux-ext4@...r.kernel.org>, <artem.blagodarenko@...il.com>, <linfeilong@...wei.com>, <liuzhiqiang26@...wei.com> Subject: Re: [PATCH v2 11/12] misc/lsattr: check whether path is NULL in lsattr_dir_proc() On 2021/7/16 11:58, Theodore Y. Ts'o wrote: > On Wed, Jun 30, 2021 at 04:27:23PM +0800, wuguanghao wrote: >> diff --git a/misc/lsattr.c b/misc/lsattr.c >> index 0d954376..f3212069 100644 >> --- a/misc/lsattr.c >> +++ b/misc/lsattr.c >> @@ -144,6 +144,12 @@ static int lsattr_dir_proc (const char * dir_name, struct dirent * de, >> int dir_len = strlen(dir_name); >> >> path = malloc(dir_len + strlen (de->d_name) + 2); >> + if (!path) { >> + fprintf(stderr, "%s", >> + _("Couldn't allocate path variable " >> + "in lsattr_dir_proc")); >> + return -1; >> + } > The string is missing a closing newline. Also, why not? > > fputs(_("Couldn't allocate path variable in lsattr_dir_proc"), > stderr); > > - Ted > > . Thanks for your suggestion. We will resend the v3 patch as your suggestion.
Powered by blists - more mailing lists