linux-ext4 - Re: remove generic_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210721053717.GA8625@lst.de>
Date:   Wed, 21 Jul 2021 07:37:17 +0200
From:   Christoph Hellwig <hch@....de>
To:     Mikulas Patocka <mikulas@...bright.com>
Cc:     Christoph Hellwig <hch@....de>, Jan Kara <jack@...e.com>,
        Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: remove generic_block_fiemap

On Tue, Jul 20, 2021 at 07:02:10PM +0200, Mikulas Patocka wrote:
> You can download a test HPFS partition here:
> http://artax.karlin.mff.cuni.cz/~mikulas/vyplody/hpfs/test-hpfs-partition.gz

looks like xfstests doesn't generally work on hpfs, and even if I tried
i would be rather slow due to the lack of sparse files.

So I tested fiemp against a few simple copied over files and it still
works.

There are some cases where the old code reported contiguous ranges
as two extents while the new one doesn't, for rasons that are not
quite clear to me:

--- fiemap.old	2021-07-21 05:00:29.000000000 +0000
+++ fiemap.iomap	2021-07-21 04:57:20.000000000 +0000
@@ -1,3 +1,2 @@
 dmesg:
-	0: [0..66]: 133817..133883
-	1: [67..67]: 133884..133884
+	0: [0..67]: 133817..133884