linux-ext4 - Re: [PATCH v4 15/16] samples: Add fs error monitoring example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Jul 2021 15:12:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>, jack@...e.com,
        amir73il@...il.com
Cc:     kbuild-all@...ts.01.org, djwong@...nel.org, tytso@....edu,
        david@...morbit.com, dhowells@...hat.com, khazhy@...gle.com,
        linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
        Gabriel Krisman Bertazi <krisman@...labora.com>
Subject: Re: [PATCH v4 15/16] samples: Add fs error monitoring example

Hi Gabriel,

I love your patch! Yet something to improve:

[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on ext4/dev ext3/for_next linus/master v5.14-rc3 next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210721-001444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/d65dd026fced2d19e194ceca1c490f32f1610a5d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210721-001444
        git checkout d65dd026fced2d19e194ceca1c490f32f1610a5d
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash samples/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   samples/fanotify/fs-monitor.c: In function 'print_fh':
>> samples/fanotify/fs-monitor.c:43:25: error: 'FILEID_INO32_GEN' undeclared (first use in this function)
      43 |  if (fh->handle_type == FILEID_INO32_GEN)
         |                         ^~~~~~~~~~~~~~~~
   samples/fanotify/fs-monitor.c:43:25: note: each undeclared identifier is reported only once for each function it appears in
>> samples/fanotify/fs-monitor.c:45:30: error: 'FILEID_INVALID' undeclared (first use in this function)
      45 |  else if (fh->handle_type == FILEID_INVALID && !h[0] && !h[1])
         |                              ^~~~~~~~~~~~~~


vim +/FILEID_INO32_GEN +43 samples/fanotify/fs-monitor.c

    31	
    32	static void print_fh(struct file_handle *fh)
    33	{
    34		int i;
    35		uint32_t *h = (uint32_t *) fh->f_handle;
    36	
    37		printf("\tfh: ");
    38		for (i = 0; i < fh->handle_bytes; i++)
    39			printf("%hhx", fh->f_handle[i]);
    40		printf("\n");
    41	
    42		printf("\tdecoded fh: ");
  > 43		if (fh->handle_type == FILEID_INO32_GEN)
    44			printf("inode=%u gen=%u\n", h[0], h[1]);
  > 45		else if (fh->handle_type == FILEID_INVALID && !h[0] && !h[1])
    46			printf("Type %d (Superblock error)\n", fh->handle_type);
    47		else
    48			printf("Type %d (Unknown)\n", fh->handle_type);
    49	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (65170 bytes)