linux-ext4 - Re: [PATCH V3 5/5] ext4: make fallocate retry when err is ENOSPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Aug 2021 17:46:25 +0200
From:   Jan Kara <jack@...e.cz>
To:     Wang Jianchao <jianchao.wan9@...il.com>
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        tytso@....edu, adilger.kernel@...ger.ca
Subject: Re: [PATCH V3 5/5] ext4: make fallocate retry when err is ENOSPC

On Wed 04-08-21 17:32:21, Jan Kara wrote:
> On Sat 24-07-21 15:41:24, Wang Jianchao wrote:
> > From: Wang Jianchao <wangjianchao@...ishou.com>
> > 
> > The blocks may be waiting for journal commit to be freed back to
> > mb buddy. Let fallocate wait and retry in that case.
> > 
> > Signed-off-by: Wang Jianchao <wangjianchao@...ishou.com>
> 
> Did you really observe this? Because the retry is already handled in
> ext4_alloc_file_blocks() that's used by ext4_fallocate(). So no retry
> should be needed there.

Oh, I can see you've addressed these already in another reply. I'll comment
there.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR