linux-ext4 - Re: [PATCH 4/9] libext2fs: Support for orphan file feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210804101332.GB4578@quack2.suse.cz>
Date:   Wed, 4 Aug 2021 12:13:32 +0200
From:   Jan Kara <jack@...e.cz>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 4/9] libext2fs: Support for orphan file feature

On Wed 04-08-21 11:25:37, Jan Kara wrote:
> On Tue 03-08-21 12:57:36, Theodore Ts'o wrote:
> > On Mon, Jul 12, 2021 at 05:43:10PM +0200, Jan Kara wrote:
> > > @@ -825,6 +826,7 @@ struct ext2_super_block {
> > >  #define EXT4_FEATURE_RO_COMPAT_GDT_CSUM		0x0010
> > >  #define EXT4_FEATURE_RO_COMPAT_DIR_NLINK	0x0020
> > >  #define EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE	0x0040
> > > +#define EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT	0x0080
> > >  #define EXT4_FEATURE_RO_COMPAT_QUOTA		0x0100
> > >  #define EXT4_FEATURE_RO_COMPAT_BIGALLOC		0x0200
> > 
> > (This isn't a full review of the patch, but just a quick feedback of
> > what I've noticed so far.)
> > 
> > Since Andreas has requested that we not get rid of the
> > RO_COMPAT_SNAPSHOT, I'm using 0x0400 for
> > EXT4_FEATURE_RO_COMPAT_ORPHAN_PRESENT in my testing.
> 
> Yeah, I'm sorry. Somehow older version of the patch escaped to this posting
> (I've checked and this was the only difference between what I have in git
> and what I have posted).
> 
> > I also noted a number of new GCC warnings when running "make gcc-wall"
> > on lib/ext2fs after applying this commit.
> 
> I'll check these fix them up and repost. Thanks for noticing.

OK, I have all the problems fixed up in my local branch. Since they were
all rather local issues and you have something working in your tree I guess
I'll wait with reposting the series if you have some other review comments.
But feel free to speak up if you want the current state of the series
posted.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR