linux-ext4 - Re: [PATCH v5 15/23] fanotify: Require fid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210805102929.GH14483@quack2.suse.cz>
Date:   Thu, 5 Aug 2021 12:29:29 +0200
From:   Jan Kara <jack@...e.cz>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     jack@...e.com, amir73il@...il.com, djwong@...nel.org,
        tytso@....edu, david@...morbit.com, dhowells@...hat.com,
        khazhy@...gle.com, linux-fsdevel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-api@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v5 15/23] fanotify: Require fid_mode for any non-fd event

On Wed 04-08-21 12:06:04, Gabriel Krisman Bertazi wrote:
> Like inode events, FAN_FS_ERROR will require fid mode.  Therefore,
> convert the verification during fanotify_mark(2) to require fid for any
> non-fd event.  This means fid_mode will not only be required for inode
> events, but for any event that doesn't provide a descriptor.
> 
> Suggested-by: Amir Goldstein <amir73il@...il.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com>

Looks good. One style nit below, otherwise feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

 
>  	/*
> -	 * Events with data type inode do not carry enough information to report
> -	 * event->fd, so we do not allow setting a mask for inode events unless
> -	 * group supports reporting fid.
> -	 * inode events are not supported on a mount mark, because they do not
> -	 * carry enough information (i.e. path) to be filtered by mount point.
> -	 */
> +	* Events that do not carry enough information to report
> +	* event->fd require a group that supports reporting fid.  Those
> +	* events are not supported on a mount mark, because they do not
> +	* carry enough information (i.e. path) to be filtered by mount
> +	* point.
> +	*/
        ^ I think these should be one column more to the right to align
with the opening /*.

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR