lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Aug 2021 17:39:55 -0400 From: Gabriel Krisman Bertazi <krisman@...labora.com> To: amir73il@...il.com, jack@...e.com Cc: linux-api@...r.kernel.org, linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, khazhy@...gle.com, dhowells@...hat.com, david@...morbit.com, tytso@....edu, djwong@...nel.org, repnop@...gle.com, Gabriel Krisman Bertazi <krisman@...labora.com>, kernel@...labora.com, Jan Kara <jack@...e.cz> Subject: [PATCH v6 06/21] inotify: Don't force FS_IN_IGNORED According to Amir: "FS_IN_IGNORED is completely internal to inotify and there is no need to set it in i_fsnotify_mask at all, so if we remove the bit from the output of inotify_arg_to_mask() no functionality will change and we will be able to overload the event bit for FS_ERROR." This is done in preparation to overload FS_ERROR with the notification mechanism in fanotify. Suggested-by: Amir Goldstein <amir73il@...il.com> Reviewed-by: Amir Goldstein <amir73il@...il.com> Reviewed-by: Jan Kara <jack@...e.cz> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.com> --- fs/notify/inotify/inotify_user.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 98f61b31745a..4d17be6dd58d 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c @@ -89,10 +89,10 @@ static inline __u32 inotify_arg_to_mask(struct inode *inode, u32 arg) __u32 mask; /* - * Everything should accept their own ignored and should receive events - * when the inode is unmounted. All directories care about children. + * Everything should receive events when the inode is unmounted. + * All directories care about children. */ - mask = (FS_IN_IGNORED | FS_UNMOUNT); + mask = (FS_UNMOUNT); if (S_ISDIR(inode->i_mode)) mask |= FS_EVENT_ON_CHILD; -- 2.32.0
Powered by blists - more mailing lists