linux-ext4 - [PATCH v2] mke2fs: warn about missing y2038 support when formatting fresh ext4 fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210812232222.GE3601392@magnolia>
Date:   Thu, 12 Aug 2021 16:22:22 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Andreas Dilger <adilger@...ger.ca>,
        linux-ext4 <linux-ext4@...r.kernel.org>
Subject: [PATCH v2] mke2fs: warn about missing y2038 support when formatting
 fresh ext4 fs

From: Darrick J. Wong <djwong@...nel.org>

Filesystems with 128-byte inodes do not support timestamps beyond the
year 2038.  Since we're now less than 16.5 years away from that point,
it's time to start warning users about this lack of support when they
format an ext4 filesystem with small inodes.

First, change the mke2fs.conf file to specify 256-byte inodes even for
small filesystems, then add a warning to mke2fs itself if someone is
trying to make us format an ext4 filesystem with 128-byte inodes.

Note that we /don't/ warn about these things if the user has signalled
that they want an old format such as ext2, ext3, or hurd.  Everyone
should know by now that those are legacy.

Signed-off-by: Darrick J. Wong <djwong@...nel.org>
---
v2: fix the comments
---
 misc/mke2fs.c       |   39 +++++++++++++++++++++++++++++++++++++++
 misc/mke2fs.conf.in |    4 ++--
 2 files changed, 41 insertions(+), 2 deletions(-)

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 92003e11..114a64f7 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -1537,6 +1537,35 @@ static int get_device_geometry(const char *file,
 }
 #endif
 
+/*
+ * Decide if the user is formatting with an old feature set (e.g. ext2, ext3).
+ *
+ * If there is no fs_types list, assume that the user's getting ext4 and return
+ * 0.  If we find 'ext4' anywhere in the fs_types list, take that as a sign
+ * that the user will get ext4 and return 0.  Any other case returns 1.
+ *
+ * Normally, 'ext4' will be the first item in fs_types, but the user can
+ * combine argv[0], -t, and -T options in such a way that fs_types will start
+ * with some other word and the 'ext4' will end up in a non-zero slot.  A
+ * simple way to do this is "mke2fs -T ext4 /dev/XXX".  The user is supposed to
+ * use -t for the fs type and not -T, but we've never enforced that.
+ */
+static inline int
+old_format_forced(char **fs_types)
+{
+	int found_ext4 = 0;
+	int i;
+
+	if (!fs_types)
+		return 0;
+
+	for (i = 0; fs_types[i]; i++)
+		if (!strcmp(fs_types[i], "ext4"))
+			found_ext4 = 1;
+
+	return !found_ext4;
+}
+
 static void PRS(int argc, char *argv[])
 {
 	int		b, c, flags;
@@ -2603,6 +2632,16 @@ static void PRS(int argc, char *argv[])
 		exit(1);
 	}
 
+	/*
+	 * If we're formatting with an ext4 feature set (and not an old ondisk
+	 * format), warn the user that filesystems with 128-byte inodes will
+	 * not work properly beyond 2038.
+	 */
+	if (!old_format_forced(fs_types) &&
+	    inode_size == EXT2_GOOD_OLD_INODE_SIZE)
+		printf(
+_("128-byte inodes cannot handle dates beyond 2038 and are deprecated\n"));
+
 	/* Make sure number of inodes specified will fit in 32 bits */
 	if (num_inodes == 0) {
 		unsigned long long n;
diff --git a/misc/mke2fs.conf.in b/misc/mke2fs.conf.in
index 01e35cf8..2fa1a824 100644
--- a/misc/mke2fs.conf.in
+++ b/misc/mke2fs.conf.in
@@ -16,12 +16,12 @@
 	}
 	small = {
 		blocksize = 1024
-		inode_size = 128
+		inode_size = 256
 		inode_ratio = 4096
 	}
 	floppy = {
 		blocksize = 1024
-		inode_size = 128
+		inode_size = 256
 		inode_ratio = 8192
 	}
 	big = {