linux-ext4 - Re: [PATCH] ext4: Fix tune2fs checksum failure for mounted filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162895105421.460437.8931255765382647790.b4-ty@mit.edu>
Date:   Sat, 14 Aug 2021 10:24:29 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Jan Kara <jack@...e.cz>
Cc:     "Theodore Ts'o" <tytso@....edu>, Boyang Xue <bxue@...hat.com>,
        linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Fix tune2fs checksum failure for mounted filesystem

On Thu, 12 Aug 2021 14:47:37 +0200, Jan Kara wrote:
> Commit 81414b4dd48 ("ext4: remove redundant sb checksum recomputation")
> removed checksum recalculation after updating superblock free space /
> inode counters in ext4_fill_super() based on the fact that we will
> recalculate the checksum on superblock writeout. That is correct
> assumption but until the writeout happens (which can take a long time)
> the checksum is incorrect in the buffer cache and if tune2fs is called
> in that time window it will complain. So return back the checksum
> recalculation and add a comment explaining the tune2fs peculiarity.
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix tune2fs checksum failure for mounted filesystem
      commit: e905fbe3fd0fdb90052f6efdf88f50a78833cfe7

Best regards,
-- 
Theodore Ts'o <tytso@....edu>