linux-ext4 - Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in FAN_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YSAlb7XGUNoc73ZJ@google.com>
Date:   Sat, 21 Aug 2021 07:58:07 +1000
From:   Matthew Bobrowski <repnop@...gle.com>
To:     krisman@...labora.com
Cc:     pvorel@...e.cz, Amir Goldstein <amir73il@...il.com>,
        Gabriel Krisman Bertazi <krisman@...labora.com>,
        kernel@...labora.com, Khazhismel Kumykov <khazhy@...gle.com>,
        Jan Kara <jack@...e.com>, Ext4 <linux-ext4@...r.kernel.org>,
        LTP List <ltp@...ts.linux.it>
Subject: Re: [LTP] [PATCH 3/7] syscalls/fanotify20: Validate incoming FID in
 FAN_FS_ERROR

Hey Gabriel,

On Fri, Aug 20, 2021 at 12:21:19PM +0200, Petr Vorel wrote:
> Hi all,
> 
> > No problem. That's what review is for ;-)
> 
> > BTW, unless anyone is specifically interested I don't think there
> > is a reason to re post the test patches before the submission request.
> > Certainly not for the small fixes that I requested.
> 
> > I do request that you post a link to a branch with the fixed test
> > so that we can experiment with the kernel patches.
> 
> > I've also CC'ed Matthew who may want to help with review of the test
> > and man page that you posted in the cover letter [1].
> 
> @Amir Thanks a lot for your review, agree with all you mentioned.
> 
> @Gabriel Thanks for your contribution. I'd also consider squashing some of the
> commits.

Is the FAN_FS_ERROR feature to be included within the 5.15 release? If so,
I may need to do some shuffling around as these LTP tests collide with the
ones I author for the FAN_REPORT_PIDFD series.

/M