linux-ext4 - Re: [PATCH] libss: add newer libreadline.so.8 to dlopen path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210823093139.GA21467@quack2.suse.cz>
Date:   Mon, 23 Aug 2021 11:31:39 +0200
From:   Jan Kara <jack@...e.cz>
To:     Theodore Ts'o <tytso@....edu>
Cc:     Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] libss: add newer libreadline.so.8 to dlopen path

On Fri 20-08-21 17:07:39, Theodore Ts'o wrote:
> On Fri, Aug 20, 2021 at 06:15:02PM +0200, Jan Kara wrote:
> > OpenSUSE Tumbleweed now has libreadline.so.8. Add it to the list of libs
> > to look for.
> > 
> > Signed-off-by: Jan Kara <jack@...e.cz>
> > ---
> >  lib/ss/get_readline.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Hum, why don't we look for libreadline.so BTW? That way we could save adding
> > now so version whenever one appears?
> 
> We do actually look for libreadline.so; it's right after
> libreadline.so.4:
> 
> > -#define DEFAULT_LIBPATH "libreadline.so.7:libreadline.so.6:libreadline.so.5:libreadline.so.4:libreadline.so:libedit.so.2:libedit.so:libeditline.so.0:libeditline.so"
> 
> However, we still need the libreadline.so.N in the path because at
> least for some distributions, they only install libreadline.so if you
> install the -dev package.  For example, in Debian, libreadline.so.8 is
> installed from the libreadline8 package, while libreadline.so is
> installed from the libreadline-dev package (and it's not guaranteed to
> be installed).

Oh, right. I've just checked and on my openSUSE machine libreadline.so is
also only provided by readline-devel package (which I have installed so I
didn't originally noticed). Thanks for explanation. I'm just wondering if
there isn't a better way to search for a suitable library...

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR