lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Aug 2021 07:44:03 +0200 From: Christoph Hellwig <hch@....de> To: Dan Williams <dan.j.williams@...el.com> Cc: Christoph Hellwig <hch@....de>, Vishal Verma <vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>, Mike Snitzer <snitzer@...hat.com>, Matthew Wilcox <willy@...radead.org>, linux-xfs <linux-xfs@...r.kernel.org>, Linux NVDIMM <nvdimm@...ts.linux.dev>, linux-fsdevel <linux-fsdevel@...r.kernel.org>, linux-ext4 <linux-ext4@...r.kernel.org> Subject: Re: [PATCH 7/9] dax: stub out dax_supported for !CONFIG_FS_DAX On Mon, Aug 23, 2021 at 02:15:47PM -0700, Dan Williams wrote: > > +static inline bool dax_supported(struct dax_device *dax_dev, > > + struct block_device *bdev, int blocksize, sector_t start, > > + sector_t len) > > +{ > > + return false; > > +} > > I've started clang-formatting new dax and nvdimm code: > > static inline bool dax_supported(struct dax_device *dax_dev, > struct block_device *bdev, int blocksize, > sector_t start, sector_t len) > { > return false; > } > > ...but I also don't mind staying consistent with the surrounding code for now. While Linux has historically used both styles, I find this second one pretty horrible. It is hard to read due to the huge amounts of wasted space, and needs constant realignment when the return type or symbol name changes.
Powered by blists - more mailing lists