lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Aug 2021 08:05:34 -0400 From: "Theodore Ts'o" <tytso@....edu> To: Denis Efremov <efremov@...ux.com> Cc: adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ext4: change EXT4_IOC_GETSTATE ioctl to _IOR On Mon, Aug 30, 2021 at 01:05:08PM +0300, Denis Efremov wrote: > EXT4_IOC_GETSTATE is only used to read the state flags from the kernel. > > Fixes: 1ad3ea6e0a69 ("ext4: add a new ioctl EXT4_IOC_GETSTATE") > Signed-off-by: Denis Efremov <efremov@...ux.com> NACK. This will break ABI compatibility, which is way important than getting the ioctl encoding incorrect. If you really care, I suppose we could add an EXT4_IOC_GETSTATE_OLD for the old value, and then support EXT4_IOC_GETSTATE and EXT4_IOC_GETSTATE_OLD for a decade or two until all of the binaries in the world get recompiled. Is it worth it? Eh.... - Ted
Powered by blists - more mailing lists