linux-ext4 - Re: [PATCH 2/3] ext4: remove dax EXPERIMENTAL warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210917094737.GE6547@quack2.suse.cz>
Date:   Fri, 17 Sep 2021 11:47:37 +0200
From:   Jan Kara <jack@...e.cz>
To:     Eric Sandeen <sandeen@...hat.com>
Cc:     linux-xfs@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, dan.j.williams@...el.com
Subject: Re: [PATCH 2/3] ext4: remove dax EXPERIMENTAL warning

On Wed 15-09-21 12:22:40, Eric Sandeen wrote:
> As there seems to be no significant outstanding concern about
> dax on ext4 at this point, remove the scary EXPERIMENTAL
> warning when in use.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

I agree. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/super.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0775950..82948d6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2346,8 +2346,6 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
>  					     "both data=journal and dax");
>  				    return -1;
>  			}
> -			ext4_msg(sb, KERN_WARNING,
> -				"DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
>  			sbi->s_mount_opt |= EXT4_MOUNT_DAX_ALWAYS;
>  			sbi->s_mount_opt2 &= ~EXT4_MOUNT2_DAX_NEVER;
>  			break;
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR