linux-ext4 - Re: [PATCH] ext4: Fix loff_t overflow in ext4_max_bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Sep 2021 23:11:13 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Ritesh Harjani <riteshh@...ux.ibm.com>, linux-ext4@...r.kernel.org
Cc:     "Theodore Ts'o" <tytso@....edu>, Jan Kara <jack@...e.cz>,
        Andreas Dilger <adilger.kernel@...ger.ca>
Subject: Re: [PATCH] ext4: Fix loff_t overflow in ext4_max_bitmap_size()

On Sat, 5 Jun 2021 10:39:32 +0530, Ritesh Harjani wrote:
> We should use unsigned long long rather than loff_t to avoid
> overflow in ext4_max_bitmap_size() for comparison before returning.
> w/o this patch sbi->s_bitmap_maxbytes was becoming a negative
> value due to overflow of upper_limit (with has_huge_files as true)
> 
> Below is a quick test to trigger it on a 64KB pagesize system.
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix loff_t overflow in ext4_max_bitmap_size()
      commit: f9b9e1afe996e8b4a0a2ea8481c41756fff53d08

Best regards,
-- 
Theodore Ts'o <tytso@....edu>