linux-ext4 - Re: [PATCH -next v2 3/6] ext4: compare to local seq and nodename when check conflict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211007123621.GH12712@quack2.suse.cz>
Date:   Thu, 7 Oct 2021 14:36:21 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ye Bin <yebin10@...wei.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        jack@...e.cz
Subject: Re: [PATCH -next v2 3/6] ext4: compare to local seq and nodename
 when check conflict

On Sat 11-09-21 17:00:56, Ye Bin wrote:
> As mmp and check_mmp is point to the same data, so there will never
> detect conflict.
> To solve this issue just compare to local data.
> 
> Signed-off-by: Ye Bin <yebin10@...wei.com>

Good spotting! Just one nit below.

> ---
>  fs/ext4/mmp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index c781b09a78c9..4433fe7e9e86 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -154,6 +154,7 @@ static int kmmpd(void *data)
>  	unsigned long last_update_time;
>  	unsigned long last_check_time;
>  	unsigned long diff;
> +	char nodename[64];

Perhaps define a constant for the length of nodename and use it here as
well as in the declaration of mmp_struct->mmp_nodename?

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR