lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Oct 2021 13:21:22 +0800 From: Coly Li <colyli@...e.de> To: Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk> Cc: Mike Snitzer <snitzer@...hat.com>, Song Liu <song@...nel.org>, David Sterba <dsterba@...e.com>, Josef Bacik <josef@...icpanda.com>, Theodore Ts'o <tytso@....edu>, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>, Dave Kleikamp <shaggy@...nel.org>, Ryusuke Konishi <konishi.ryusuke@...il.com>, Anton Altaparmakov <anton@...era.com>, Konstantin Komarov <almaz.alexandrovich@...agon-software.com>, Kees Cook <keescook@...omium.org>, Phillip Lougher <phillip@...ashfs.org.uk>, Jan Kara <jack@...e.com>, linux-block@...r.kernel.org, dm-devel@...hat.com, drbd-dev@...ts.linbit.com, linux-bcache@...r.kernel.org, linux-raid@...r.kernel.org, linux-mtd@...ts.infradead.org, linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-ext4@...r.kernel.org, jfs-discussion@...ts.sourceforge.net, linux-nfs@...r.kernel.org, linux-nilfs@...r.kernel.org, linux-ntfs-dev@...ts.sourceforge.net, ntfs3@...ts.linux.dev, reiserfs-devel@...r.kernel.org Subject: Re: [PATCH 01/29] bcache: remove bdev_sectors On 10/13/21 1:10 PM, Christoph Hellwig wrote: > Use the equivalent block layer helper instead. > > Signed-off-by: Christoph Hellwig <hch@....de> Acked-by: Coly Li <colyli@...e.de> Thanks. Coly Li > --- > drivers/md/bcache/super.c | 2 +- > drivers/md/bcache/util.h | 4 ---- > drivers/md/bcache/writeback.c | 2 +- > 3 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index f2874c77ff797..4f89985abe4b7 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1002,7 +1002,7 @@ static void calc_cached_dev_sectors(struct cache_set *c) > struct cached_dev *dc; > > list_for_each_entry(dc, &c->cached_devs, list) > - sectors += bdev_sectors(dc->bdev); > + sectors += bdev_nr_sectors(dc->bdev); > > c->cached_dev_sectors = sectors; > } > diff --git a/drivers/md/bcache/util.h b/drivers/md/bcache/util.h > index b64460a762677..a7da7930a7fda 100644 > --- a/drivers/md/bcache/util.h > +++ b/drivers/md/bcache/util.h > @@ -584,8 +584,4 @@ static inline unsigned int fract_exp_two(unsigned int x, > void bch_bio_map(struct bio *bio, void *base); > int bch_bio_alloc_pages(struct bio *bio, gfp_t gfp_mask); > > -static inline sector_t bdev_sectors(struct block_device *bdev) > -{ > - return bdev->bd_inode->i_size >> 9; > -} > #endif /* _BCACHE_UTIL_H */ > diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c > index 8120da278161e..c7560f66dca88 100644 > --- a/drivers/md/bcache/writeback.c > +++ b/drivers/md/bcache/writeback.c > @@ -45,7 +45,7 @@ static uint64_t __calc_target_rate(struct cached_dev *dc) > * backing volume uses about 2% of the cache for dirty data. > */ > uint32_t bdev_share = > - div64_u64(bdev_sectors(dc->bdev) << WRITEBACK_SHARE_SHIFT, > + div64_u64(bdev_nr_sectors(dc->bdev) << WRITEBACK_SHARE_SHIFT, > c->cached_dev_sectors); > > uint64_t cache_dirty_target =
Powered by blists - more mailing lists